Re: Hash index AM fake LSN oversight

Поиск
Список
Период
Сортировка
Искать
От
Peter Geoghegan
Тема
Re: Hash index AM fake LSN oversight
Дата
в 01:11:18
Msg-id
CAH2-WznfA==hUFdN8YEYkhFiTL0X_roQ1MDeCiRygfqZLNDw+A@mail.gmail.com
Ответ на
Список
Дерево обсуждения
Hash index AM fake LSN oversight Peter Geoghegan <pg@bowt.ie>
Re: Hash index AM fake LSN oversight Ewan Young <kdbase.hack@gmail.com>
Re: Hash index AM fake LSN oversight Peter Geoghegan <pg@bowt.ie>
On Wed, Jul 15, 2026 at 2:47 AM Ewan Young  wrote:
> Confirmed -- log_split_page() is the only data-page site e5836f7b left
> without a fake-LSN branch (the _hash_init meta/bitmap paths set the LSN
> under WAL only, but those aren't read concurrently, so that's expected).
> The fix is correct.

Pushed. Thanks for the review!

> One optional cosmetic point: the other fake-LSN sites, including the two
> functions e5836f7b just reworked in this file, hoist recptr out of the
> if and call PageSetLSN once afterwards, rather than once per branch.

I agree that it works slightly better that way; that's what I did in
the committed version.

--
Peter Geoghegan


В списке pgsql-hackers по дате отправления
От: Michael Paquier
Дата:
От: Jelte Fennema-Nio
Дата:
FAQ