Re: Support reset of Shared objects statistics in "pg_stat_reset" function

Поиск
Список
Период
Сортировка
Искать
От
Sadhuprasad Patro
Тема
Re: Support reset of Shared objects statistics in "pg_stat_reset" function
Дата
Msg-id
CAFF0-CHSFD4=E4UvDEQeh-JwNj_aQ4XRuaD2gUKcV5b+qshY+A@mail.gmail.com
Ответ на
Список
Дерево обсуждения
Support reset of Shared objects statistics in "pg_stat_reset" function Sadhuprasad Patro <b.sadhu@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Mahendra Singh Thalor <mahi6run@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Himanshu Upadhyaya <upadhyaya.himanshu@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Mahendra Singh Thalor <mahi6run@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Himanshu Upadhyaya <upadhyaya.himanshu@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Dilip Kumar <dilipbalaut@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Mahendra Singh Thalor <mahi6run@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Mahendra Singh Thalor <mahi6run@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Sadhuprasad Patro <b.sadhu@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Sadhuprasad Patro <b.sadhu@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Mahendra Singh Thalor <mahi6run@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Mahendra Singh Thalor <mahi6run@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Sadhuprasad Patro <b.sadhu@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Mahendra Singh Thalor <mahi6run@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Mahendra Singh Thalor <mahi6run@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Dilip Kumar <dilipbalaut@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Mahendra Singh Thalor <mahi6run@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Sadhuprasad Patro <b.sadhu@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Sadhuprasad Patro <b.sadhu@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Mahendra Singh Thalor <mahi6run@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Fujii Masao <masao.fujii@oss.nttdata.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Sadhuprasad Patro <b.sadhu@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Mahendra Singh Thalor <mahi6run@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Fujii Masao <masao.fujii@oss.nttdata.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Sadhuprasad Patro <b.sadhu@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Fujii Masao <masao.fujii@oss.nttdata.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Sadhuprasad Patro <b.sadhu@gmail.com>
Re: Support reset of Shared objects statistics in "pg_stat_reset" function Mahendra Singh Thalor <mahi6run@gmail.com>
> 3)
> -       dbentry = pgstat_get_db_entry(msg->m_databaseid, false);
> +       if (!IsSharedRelation(msg->m_objectid))
> +               dbentry = pgstat_get_db_entry(msg->m_databaseid, false);
> +       else
> +               dbentry = pgstat_get_db_entry(InvalidOid, false);
>
> We should add some comments before this change.

In my opinion, the comments added above the function
"pgstat_recv_resetsinglecounter" and the function call
"IsSharedRelation" added are self explanatory. If we add anything
more, it will be a duplication.
So No need to add any more comments here.


Thanks & Regards
SadhuPrasad
EnterpriseDB: http://www.enterprisedb.com


В списке pgsql-hackers по дате отправления
От: 蔡梦娟(玊于)
Дата:
От: Sadhuprasad Patro
Дата:
FAQ