Re: [PATCH] Partial foreign key updates in referential integrity triggers

Поиск
Список
Период
Сортировка
Искать
От
Paul Martinez
Тема
Re: [PATCH] Partial foreign key updates in referential integrity triggers
Дата
Msg-id
CAF+2_SFTfdOK+bXuoCvvhJxLbRwtmZdPy5R6dAu7h=E6Hbu-6w@mail.gmail.com
Ответ на
Re: [PATCH] Partial foreign key updates in referential integrity triggers (Zhihong Yu)
Список
Дерево обсуждения
[PATCH] Partial foreign key updates in referential integrity triggers Paul Martinez <paulmtz@google.com>
Re: [PATCH] Partial foreign key updates in referential integrity triggers Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Re: [PATCH] Partial foreign key updates in referential integrity triggers Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Re: [PATCH] Partial foreign key updates in referential integrity triggers Ibrar Ahmed <ibrar.ahmad@gmail.com>
Re: [PATCH] Partial foreign key updates in referential integrity triggers Paul Martinez <hellopfm@gmail.com>
Re: [PATCH] Partial foreign key updates in referential integrity triggers Daniel Gustafsson <daniel@yesql.se>
Re: [PATCH] Partial foreign key updates in referential integrity triggers Paul Martinez <hellopfm@gmail.com>
Re: [PATCH] Partial foreign key updates in referential integrity triggers Zhihong Yu <zyu@yugabyte.com>
Re: [PATCH] Partial foreign key updates in referential integrity triggers Paul Martinez <hellopfm@gmail.com>
Re: [PATCH] Partial foreign key updates in referential integrity triggers Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Re: [PATCH] Partial foreign key updates in referential integrity triggers Paul Martinez <hellopfm@gmail.com>
Re: [PATCH] Partial foreign key updates in referential integrity triggers Zhihong Yu <zyu@yugabyte.com>
Re: [PATCH] Partial foreign key updates in referential integrity triggers Paul Martinez <hellopfm@gmail.com>
Re: [PATCH] Partial foreign key updates in referential integrity triggers Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Re: [PATCH] Partial foreign key updates in referential integrity triggers Matthias van de Meent <boekewurm+postgres@gmail.com>
Re: [PATCH] Partial foreign key updates in referential integrity triggers Paul Martinez <hellopfm@gmail.com>
Re: [PATCH] Partial foreign key updates in referential integrity triggers Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Re: [PATCH] Partial foreign key updates in referential integrity triggers David Steele <david@pgmasters.net>
Re: [PATCH] Partial foreign key updates in referential integrity triggers David Steele <david@pgmasters.net> 
On Mon, Nov 22, 2021 at 10:21 PM Zhihong Yu  wrote:
>
> Hi,
> +       If a foreign key with a SET NULL or SET
> +       DEFAULT delete action, which columns should be updated.
>
> which columns should be updated -> the columns that should be updated

Done.

> +   if (fk_del_set_cols)
> +   {
> +       int num_delete_cols = 0;
>
> Since num_delete_cols is only used in the else block, I think it can be moved inside else block.
> Or you can store the value inside *num_fk_del_set_cols directly and avoid num_delete_cols.

I've moved it inside the else block (and removed the initialization).

Updated patch attached. Thanks for taking a look so quickly!

- Paul
В списке pgsql-hackers по дате отправления
Предыдущее
От: Zhihong Yu
Дата:
Следующее
От: Tomas Vondra
Дата:
FAQ