[MASSMAIL]Fix resource leak (src/backend/libpq/be-secure-common.c)
От
Ranier Vilela
Тема
[MASSMAIL]Fix resource leak (src/backend/libpq/be-secure-common.c)
Дата
Msg-id
CAEudQAqMeE0AHcOsOzZx51Z0eiFJAjhBPRFt+Bxi3ETXWen7ig@mail.gmail.com
Список
Дерево обсуждения
[MASSMAIL]Fix resource leak (src/backend/libpq/be-secure-common.c) Ranier Vilela <ranier.vf@gmail.com>
Re: Fix resource leak (src/backend/libpq/be-secure-common.c) Daniel Gustafsson <daniel@yesql.se>
Re: Fix resource leak (src/backend/libpq/be-secure-common.c) Ranier Vilela <ranier.vf@gmail.com>
Re: Fix resource leak (src/backend/libpq/be-secure-common.c) Daniel Gustafsson <daniel@yesql.se>
Re: Fix resource leak (src/backend/libpq/be-secure-common.c) Ranier Vilela <ranier.vf@gmail.com>
Re: Fix resource leak (src/backend/libpq/be-secure-common.c) Daniel Gustafsson <daniel@yesql.se>
Re: Fix resource leak (src/backend/libpq/be-secure-common.c) Michael Paquier <michael@paquier.xyz>
Re: Fix resource leak (src/backend/libpq/be-secure-common.c) Daniel Gustafsson <daniel@yesql.se>
Re: Fix resource leak (src/backend/libpq/be-secure-common.c) Ranier Vilela <ranier.vf@gmail.com>
Hi,
Per Coverity.
Coverity reported a resource leak at the function run_ssl_passphrase_command.
8. noescape: Assuming resource wait_result_to_str(pclose_rc) is not freed or pointed-to as ellipsis argument to errdetail_internal.
CID 1533043: (#1 of 1): Resource leak (RESOURCE_LEAK)
9. leaked_storage: Failing to save or free storage allocated by wait_result_to_str(pclose_rc) leaks it.I think that Coverity is right.
Fix by freeing the pointer, like pclose_check (src/common/exec.c) similar case.
Patch attached.
best regards,
В списке pgsql-hackers по дате отправления
