Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c)
От
Ranier Vilela
Тема
Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c)
Дата
Msg-id
CAEudQAqD7f2i4iyEaAz-5o-bf6zXVX-AkNUBm-YjUXEemaEh6A@mail.gmail.com
Список
Дерево обсуждения
Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c) Ranier Vilela <ranier.vf@gmail.com>
Re: Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c) Tomas Vondra <tomas.vondra@enterprisedb.com>
Re: Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c) Ranier Vilela <ranier.vf@gmail.com>
Re: Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c) Tomas Vondra <tomas.vondra@enterprisedb.com>
Re: Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c) Ranier Vilela <ranier.vf@gmail.com>
Re: Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c) Tomas Vondra <tomas.vondra@enterprisedb.com>
Re: Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c) Ranier Vilela <ranier.vf@gmail.com>
Re: Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c) Tomas Vondra <tomas.vondra@enterprisedb.com>
Re: Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c) Ranier Vilela <ranier.vf@gmail.com>
Re: Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c) Tomas Vondra <tomas.vondra@enterprisedb.com>
Re: Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c) Ranier Vilela <ranier.vf@gmail.com>
Hi,
The commit b437571 I think has an oversight.
When allocate memory and initialize private spool in function:
_brin_leader_participate_as_worker
The behavior is the bs_spool (heap and index fields)
are left empty.
The code affected is:
buildstate->bs_spool = (BrinSpool *) palloc0(sizeof(BrinSpool));
- buildstate->bs_spool->heap = buildstate->bs_spool->heap;
- buildstate->bs_spool->index = buildstate->bs_spool->index;
+ buildstate->bs_spool->heap = heap;
+ buildstate->bs_spool->index = index;
- buildstate->bs_spool->heap = buildstate->bs_spool->heap;
- buildstate->bs_spool->index = buildstate->bs_spool->index;
+ buildstate->bs_spool->heap = heap;
+ buildstate->bs_spool->index = index;
Is the fix correct?
best regards,
Ranier Vilela
В списке pgsql-hackers по дате отправления
От: Tomas Vondra
Дата: