[pgadmin-hackers][patch] Raise InternalServerError while retrievingtable DDL
От
Joao Pedro De Almeida Pereira
Тема
[pgadmin-hackers][patch] Raise InternalServerError while retrievingtable DDL
Дата
Msg-id
CAE+jjan4MxTxtKTOcmFJFavZbJKB+S=4NwkHipPmyz8V=_MS7Q@mail.gmail.com
Список
Дерево обсуждения
[pgadmin-hackers][patch] Raise InternalServerError while retrievingtable DDL Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io>
Re: [patch] Raise InternalServerError whileretrieving table DDL Dave Page <dpage@pgadmin.org>
Re: [patch] Raise InternalServerError whileretrieving table DDL Ashesh Vashi <ashesh.vashi@enterprisedb.com>
Re: [patch] Raise InternalServerError whileretrieving table DDL Atira Odhner <aodhner@pivotal.io>
Re: [patch] Raise InternalServerError whileretrieving table DDL Ashesh Vashi <ashesh.vashi@enterprisedb.com>
Hi Hackers,
While doing the DDL patch we found out that the code was not working properly when errors happened during SQL execution:
One example of this can be found in the file:
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py
The function '_formatter' that returns internal_server_error when an error occur executing SQL
Nevertheless the 'sql' function uses the output of '_formatter' during the execution without checking it.
To solve this issue we raise an InternalServerError exception that we catch in the 'sql' function instead of returning an error message.
Thanks
Joao & Sarah
В списке pgadmin-hackers по дате отправления
От: Joao Pedro De Almeida Pereira
Дата:
