Re: BUG #14929: Unchecked AllocateDir() return value in restoreTwoPhaseData()

On Mon, Nov 27, 2017 at 7:35 PM, Amit Langote
 wrote:
> It seems like a good idea to check cldir for NULL before freeing.  Please
> find attached a patch to implement the same.

There are other places where this could be added like
CheckPointLogicalRewriteHeap() if you'd like to make the code more
consistent, but my opinion would be on the contrary to drop all the
checks after AllocateDir if ReadDir is directly used. Not worth
bothering at the end.
-- 
Michael