Re: Can we get rid of TerminateThread() in pg_dump?
От
Thomas Munro
Тема
Re: Can we get rid of TerminateThread() in pg_dump?
Дата
Msg-id
CA+hUKG+4ULA_-bW0Fws8SoJGWgS49d76kB264A7yC8pH=k_joQ@mail.gmail.com
Ответ на
Re: Can we get rid of TerminateThread() in pg_dump? (Heikki Linnakangas)
Список
Дерево обсуждения
Can we get rid of TerminateThread() in pg_dump? Thomas Munro <thomas.munro@gmail.com>
Re: Can we get rid of TerminateThread() in pg_dump? Heikki Linnakangas <hlinnaka@iki.fi>
Re: Can we get rid of TerminateThread() in pg_dump? Bryan Green <dbryan.green@gmail.com>
Re: Can we get rid of TerminateThread() in pg_dump? Thomas Munro <thomas.munro@gmail.com>
Re: Can we get rid of TerminateThread() in pg_dump? "Jelte Fennema-Nio" <postgres@jeltef.nl>
Re: Can we get rid of TerminateThread() in pg_dump? Bryan Green <dbryan.green@gmail.com>
Re: Can we get rid of TerminateThread() in pg_dump? Thomas Munro <thomas.munro@gmail.com>
Re: Can we get rid of TerminateThread() in pg_dump? Heikki Linnakangas <hlinnaka@iki.fi>
Re: Can we get rid of TerminateThread() in pg_dump? Heikki Linnakangas <hlinnaka@iki.fi>
Re: Can we get rid of TerminateThread() in pg_dump? Thomas Munro <thomas.munro@gmail.com>
Re: Can we get rid of TerminateThread() in pg_dump? "Jelte Fennema-Nio" <postgres@jeltef.nl>
Re: Can we get rid of TerminateThread() in pg_dump? Heikki Linnakangas <hlinnaka@iki.fi>
Re: Can we get rid of TerminateThread() in pg_dump? Jelte Fennema-Nio <postgres@jeltef.nl>
Re: Can we get rid of TerminateThread() in pg_dump? Jelte Fennema-Nio <postgres@jeltef.nl>
Re: Can we get rid of TerminateThread() in pg_dump? Thomas Munro <thomas.munro@gmail.com>
Re: Can we get rid of TerminateThread() in pg_dump? Bryan Green <dbryan.green@gmail.com>
Re: Can we get rid of TerminateThread() in pg_dump? Thomas Munro <thomas.munro@gmail.com>
Re: Can we get rid of TerminateThread() in pg_dump? Bryan Green <dbryan.green@gmail.com>
On Tue, Jul 7, 2026 at 9:23 AM Heikki Linnakangas wrote: > In this case, though, I think all we need is a "volatile sigatomic_t" > flag. Sending the query cancellation over the network surely acts as a > full compiler and memory barrier in the cancelling thread. And similarly > receiving the error message from the network acts as a full barrier in > the other threads that might receive the cancellation error from the > backend. You're right. So basically Jelte's patch, except it doesn't need the Win32 atomics stuff, just volatile, and a comment to explain that assumption. (Then some later version could use an explicit barrier instead of a comment, I guess, just to be clearer.)
В списке pgsql-hackers по дате отправления
От: Jeff Davis
Дата: