Re: Compress prune/freeze records with Delta Frame of Reference algorithm

Поиск
Список
Период
Сортировка
Искать
От
Evgeny Voropaev
Тема
Re: Compress prune/freeze records with Delta Frame of Reference algorithm
Дата
в 13:05:41
Msg-id
8b8eefc8-7e96-411c-813f-636af38966f9@tantorlabs.com
Ответ на
Список
Дерево обсуждения
Compress prune/freeze records with Delta Frame of Reference algorithm Evgeny Voropaev <evgeny.voropaev@tantorlabs.com>
Re: Compress prune/freeze records with Delta Frame of Reference algorithm Andrey Borodin <x4mmm@yandex-team.ru>
Re: Compress prune/freeze records with Delta Frame of Reference algorithm Evgeny Voropaev <evgeny.voropaev@tantorlabs.com>
Re: Compress prune/freeze records with Delta Frame of Reference algorithm Evgeny Voropaev <evgeny.voropaev@tantorlabs.com>
Re: Compress prune/freeze records with Delta Frame of Reference algorithm Andres Freund <andres@anarazel.de>
Re: Compress prune/freeze records with Delta Frame of Reference algorithm Evgeny Voropaev <evgeny.voropaev@tantorlabs.com>
Re: Compress prune/freeze records with Delta Frame of Reference algorithm Tomas Vondra <tomas@vondra.me>
Re: Compress prune/freeze records with Delta Frame of Reference algorithm Evgeny Voropaev <evgeny.voropaev@tantorlabs.com>
Re: Compress prune/freeze records with Delta Frame of Reference algorithm Evgeny Voropaev <evgeny.voropaev@tantorlabs.com>
Re: Compress prune/freeze records with Delta Frame of Reference algorithm Evgeny Voropaev <evgeny.voropaev@tantorlabs.com>
Re: Compress prune/freeze records with Delta Frame of Reference algorithm Andres Freund <andres@anarazel.de>
Re: Compress prune/freeze records with Delta Frame of Reference algorithm Andrey Borodin <x4mmm@yandex-team.ru>
Re: Compress prune/freeze records with Delta Frame of Reference algorithm Evgeny Voropaev <evgeny.voropaev@tantorlabs.com>
Re: Compress prune/freeze records with Delta Frame of Reference algorithm Evgeny Voropaev <evgeny.voropaev@tantorlabs.com>
Re: Compress prune/freeze records with Delta Frame of Reference algorithm Evgeny Voropaev <evgeny.voropaev@tantorlabs.com>
Re: Compress prune/freeze records with Delta Frame of Reference algorithm Evgeny Voropaev <evgeny.voropaev@tantorlabs.com>
Re: Compress prune/freeze records with Delta Frame of Reference algorithm Evgeny Voropaev <evgeny.voropaev@tantorlabs.com>
Re: Compress prune/freeze records with Delta Frame of Reference algorithm Heikki Linnakangas <hlinnaka@iki.fi>
Re: Compress prune/freeze records with Delta Frame of Reference algorithm Evgeny Voropaev <evgeny.voropaev@tantorlabs.com>
Re: Compress prune/freeze records with Delta Frame of Reference algorithm Evgeny Voropaev <evgeny.voropaev@tantorlabs.com>
Re: Compress prune/freeze records with Delta Frame of Reference algorithm Heikki Linnakangas <hlinnaka@iki.fi>
Re: Compress prune/freeze records with Delta Frame of Reference algorithm Andrey Borodin <x4mmm@yandex-team.ru>
Hello Andrey,

 > Great idea and nice library for DFoR! Thank you for your attention.
I wish the patch would be useful.

All your proposals and recommendations have been implemented in v02.
Also the meson settings has been updated for supporting the new
developments.

 > Perhaps, first thing to start is to fix CI failures

Once meson is fixed, tests should pass successfully now. Looking
forward to this.

 > As a minor nit: do not use stdlib assert(), use capital Assert()

Done.

 > Are we 100% sure qsort() won't allocate something anywhere?
 > sort_template.h seems to be allocation-free, but just in case...

No guarantees from libraries or from descriptions about qsort's
behaviour regarding dynamic memory allocation. So, the qsort is just
substituted with the sort_template, which we trust, and as you
proposed.

Waiting for tests to have passed, and then I hope we could move further.

Best regards, Evgeny Voropaev.
В списке pgsql-hackers по дате отправления
FAQ