Call perror on popen failure
От
Daniel Gustafsson
Тема
Call perror on popen failure
Дата
Msg-id
89B00F63-40F7-4D82-8353-DC9CABBAC1D1@yesql.se
Список
Дерево обсуждения
Call perror on popen failure Daniel Gustafsson <daniel@yesql.se>
Re: Call perror on popen failure Peter Eisentraut <peter@eisentraut.org>
Re: Call perror on popen failure Daniel Gustafsson <daniel@yesql.se>
Re: Call perror on popen failure Tom Lane <tgl@sss.pgh.pa.us>
If popen fails in pipe_read_line we invoke perror for the error message, and pipe_read_line is in turn called by find_other_exec which is used in both frontend and backend code. This is an old codepath, and it seems like it ought to be replaced with the more common logging tools we now have like in the attached diff (which also makes the error translated as opposed to now). Any objections to removing this last perror() call? -- Daniel Gustafsson
В списке pgsql-hackers по дате отправления