Re: typedef struct WindowClause misleading comments

Поиск
Список
Период
Сортировка
Искать
От
Tom Lane
Тема
Re: typedef struct WindowClause misleading comments
Дата
в 19:54:49
Msg-id
892312.1781024089@sss.pgh.pa.us
Ответ на
Список
Дерево обсуждения
typedef struct WindowClause misleading comments jian he <jian.universality@gmail.com>
Re: typedef struct WindowClause misleading comments David Rowley <dgrowleyml@gmail.com>
Re: typedef struct WindowClause misleading comments Tom Lane <tgl@sss.pgh.pa.us>
Re: typedef struct WindowClause misleading comments David Rowley <dgrowleyml@gmail.com>
Re: typedef struct WindowClause misleading comments Tom Lane <tgl@sss.pgh.pa.us>
Re: typedef struct WindowClause misleading comments David Rowley <dgrowleyml@gmail.com>
Re: typedef struct WindowClause misleading comments jian he <jian.universality@gmail.com>
David Rowley  writes:
> On Tue, 9 Jun 2026 at 13:56, jian he  wrote:
>> Query jumbling considers the ORDER BY clause; therefore, the comment
>> below is inaccurate.
>> 
>> /
>> * The information relevant for the query jumbling is the partition clause
>> * type and its bounds.
>> */

> I think the comment should be deleted.  It's pretty obvious which
> fields are used by looking at the pg_node_attr(query_jumble_ignore)
> attributes.

+1.  There are also other comments about query jumbling in nodes/*.h that
seem pretty information-free now.  They might have been helpful before
we invented query_jumble_ignore and related annotations, but now they
seem just duplicative.

			regards, tom lane


В списке pgsql-hackers по дате отправления
От: Tom Lane
Дата:
FAQ