Re: msvc const warnings

Поиск
Список
Период
Сортировка
Искать
От
Gregory Stark
Тема
Re: msvc const warnings
Дата
Msg-id
871wex3nvy.fsf@oxford.xeocode.com
Ответ на
msvc const warnings (Magnus Hagander)
Список
Дерево обсуждения
msvc const warnings Magnus Hagander <magnus@hagander.net>
Re: msvc const warnings Gregory Stark <stark@enterprisedb.com>
Re: msvc const warnings Tom Lane <tgl@sss.pgh.pa.us>
Re: msvc const warnings Gregory Stark <stark@enterprisedb.com>
Re: msvc const warnings Tom Lane <tgl@sss.pgh.pa.us>
Re: msvc const warnings Magnus Hagander <magnus@hagander.net>
Re: msvc const warnings Tom Lane <tgl@sss.pgh.pa.us>
Re: msvc const warnings Magnus Hagander <magnus@hagander.net>
Re: msvc const warnings Magnus Hagander <magnus@hagander.net>
Re: msvc const warnings Andrew Dunstan <andrew@dunslane.net>
Re: msvc const warnings Peter Eisentraut <peter_e@gmx.net>
"Magnus Hagander"  writes:

> Stefan mentioned that the warning may be one that shows up in a different
> compiler somewhere as well, thouh, which might indicate that we should fix
> the underlying issue? (Even if the code is correct, if it confuses multiple
> compilers...)

I think the right fix is just to remove the const qualifier. It's clearly not
treating the pointer as const if it's passing it to pfree which is surely a
state change if anything is.

We do far too much casting to (void*) as it is and I would dearly love to go
through the whole source tree and remove all the redundant casts. All they do
is cover up real type clash bugs.

-- 
  Gregory Stark
  EnterpriseDB          http://www.enterprisedb.com

В списке pgsql-patches по дате отправления
От: Tom Lane
Дата:
Сообщение: Re: plperl warnings on win32
От: Tom Lane
Дата:
FAQ