Re: [HACKERS] Relcache leak when row triggers on partitions are firedby COPY

Поиск
Список
Период
Сортировка
Искать
От
Amit Langote
Тема
Re: [HACKERS] Relcache leak when row triggers on partitions are firedby COPY
Дата
в 04:17:51
Msg-id
75267993-08c4-3e55-242d-2142e9622699@lab.ntt.co.jp
Ответ на
Список
Дерево обсуждения
[HACKERS] Relcache leak when row triggers on partitions are fired by COPY Thomas Munro <thomas.munro@enterprisedb.com>
Re: [HACKERS] Relcache leak when row triggers on partitions are firedby COPY Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Re: [HACKERS] Relcache leak when row triggers on partitions are firedby COPY Thomas Munro <thomas.munro@enterprisedb.com>
Re: [HACKERS] Relcache leak when row triggers on partitions are firedby COPY Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Re: [HACKERS] Relcache leak when row triggers on partitions are firedby COPY Robert Haas <robertmhaas@gmail.com>
On 2017/05/16 10:03, Thomas Munro wrote:
> On Tue, May 16, 2017 at 12:32 PM, Amit Langote
>  wrote:
>> I vote for ExecCleanupTriggerState(estate).  After your patch, there will
>> be 4 places, including afterTriggerInvokeEvents(), ExecEndPlan(), and
>> EvalPlanQualEnd(), that repeat the same block of code.
> 
> Ok, here's a patch like that.

Thanks, looks good to me.

>  The call to ExecCloseIndices() may
> technically be redundant (we never opened them).

Actually yes.  We never do ExecOpenIndices() on the ResultRelInfos
contained in es_trig_target_relations.

Thanks,
Amit



В списке pgsql-hackers по дате отправления
От: Masahiko Sawada
Дата:
От: Masahiko Sawada
Дата:
FAQ