Re: Fix for edge case in date_bin() function

Поиск
Список
Период
Сортировка
Искать
От
Daniel Gustafsson
Тема
Re: Fix for edge case in date_bin() function
Дата
Msg-id
6200ACB3-8ECF-487B-8F9D-290BBEE146B4@yesql.se
Ответ на
Список
Дерево обсуждения
Fix for edge case in date_bin() function Moaaz Assali <ma5679@nyu.edu>
Re: Fix for edge case in date_bin() function Tom Lane <tgl@sss.pgh.pa.us>
Re: Fix for edge case in date_bin() function Tom Lane <tgl@sss.pgh.pa.us>
Re: Fix for edge case in date_bin() function Moaaz Assali <ma5679@nyu.edu>
Re: Fix for edge case in date_bin() function Tom Lane <tgl@sss.pgh.pa.us>
Re: Fix for edge case in date_bin() function Moaaz Assali <ma5679@nyu.edu>
Re: Fix for edge case in date_bin() function Tom Lane <tgl@sss.pgh.pa.us>
Re: Fix for edge case in date_bin() function Daniel Gustafsson <daniel@yesql.se>
Re: Fix for edge case in date_bin() function Moaaz Assali <ma5679@nyu.edu>
> On 27 Feb 2024, at 09:42, Moaaz Assali  wrote:

> To account for this edge, we simply add another condition in the if statement to not perform the subtraction by one stride interval if the time difference is divisible by the stride.

I only skimmed the patch, but I recommend adding a testcase to it to keep the
regression from reappearing.  src/test/regress/sql/timestamp.sql might be a
good candidate testsuite.

--
Daniel Gustafsson



В списке pgsql-hackers по дате отправления
От: Moaaz Assali
Дата:
От: Benoit Lobréau
Дата:
FAQ