Re: Add LogicalTapeSetExtend() to logtape.c

Поиск
Список
Период
Сортировка
Искать
От
Jeff Davis
Тема
Re: Add LogicalTapeSetExtend() to logtape.c
Дата
Msg-id
619e61919fd604c2caa629536ee87615b732e054.camel@j-davis.com
Ответ на
Список
Дерево обсуждения
Add LogicalTapeSetExtend() to logtape.c Jeff Davis <pgsql@j-davis.com>
Re: Add LogicalTapeSetExtend() to logtape.c Adam Lee <ali@pivotal.io>
Re: Add LogicalTapeSetExtend() to logtape.c Jeff Davis <pgsql@j-davis.com>
Re: Add LogicalTapeSetExtend() to logtape.c Adam Lee <ali@pivotal.io>
Re: Add LogicalTapeSetExtend() to logtape.c Jeff Davis <pgsql@j-davis.com>
Re: Add LogicalTapeSetExtend() to logtape.c Adam Lee <ali@pivotal.io>
Re: Add LogicalTapeSetExtend() to logtape.c Jeff Davis <pgsql@j-davis.com>
Re: Add LogicalTapeSetExtend() to logtape.c Jeff Davis <pgsql@j-davis.com>
On Fri, 2020-02-28 at 14:16 +0800, Adam Lee wrote:
> I noticed another difference, I was using palloc0(), which could be
> one of the
> reason, but not sure.

I changed the palloc0()'s in your code to plain palloc(), and it didn't
make any perceptible difference. Still slower than the version I posted
that keeps the flexible array.

Did you compare all 3? Master, with your patch, and with my patch? I'd
like to see if you're seeing the same thing that I am.

> Tested your hashagg-20200226.patch on my laptop(Apple clang version
> 11.0.0),
> the average time is 25.9s:

That sounds high -- my runs are about half that time. Is that with a
debug build or an optimized one?

Regards,
	Jeff Davis





В списке pgsql-hackers по дате отправления
От: Tom Lane
Дата:
От: Alvaro Herrera
Дата:
FAQ