Re: BUG #12694: crash if the number of result rows is lower than gin_fuzzy_search_limit
От
Tom Lane
Тема
Re: BUG #12694: crash if the number of result rows is lower than gin_fuzzy_search_limit
Дата
Msg-id
4773.1422545177@sss.pgh.pa.us
Ответ на
Re: BUG #12694: crash if the number of result rows is lower
than gin_fuzzy_search_limit (Heikki Linnakangas)
Список
Дерево обсуждения
BUG #12694: crash if the number of result rows is lower than
gin_fuzzy_search_limit olaf.gw@googlemail.com
Re: BUG #12694: crash if the number of result rows is lower
than gin_fuzzy_search_limit Michael Paquier <michael.paquier@gmail.com>
Re: BUG #12694: crash if the number of result rows is lower
than gin_fuzzy_search_limit Heikki Linnakangas <hlinnakangas@vmware.com>
Re: BUG #12694: crash if the number of result rows is lower than gin_fuzzy_search_limit Tom Lane <tgl@sss.pgh.pa.us>
Re: BUG #12694: crash if the number of result rows is lower
than gin_fuzzy_search_limit Heikki Linnakangas <hlinnakangas@vmware.com>
Re: BUG #12694: crash if the number of result rows is lower than gin_fuzzy_search_limit Tom Lane <tgl@sss.pgh.pa.us>
Re: BUG #12694: crash if the number of result rows is lower
than gin_fuzzy_search_limit Heikki Linnakangas <hlinnakangas@vmware.com>
Re: BUG #12694: crash if the number of result rows is lower than gin_fuzzy_search_limit Tom Lane <tgl@sss.pgh.pa.us>
Re: BUG #12694: crash if the number of result rows is lower
than gin_fuzzy_search_limit Heikki Linnakangas <hlinnakangas@vmware.com>
Re: BUG #12694: crash if the number of result rows is lower
than gin_fuzzy_search_limit Heikki Linnakangas <hlinnakangas@vmware.com>
Heikki Linnakangas writes: > The fix is simple: make sure that startScanKey() is always called, by > getting rid of the early return above. Attached. I'll apply this later > today or tomorrow unless someone sees a problem with this. Another, even simpler fix would be to just move the startScanKey() call loop to before the "if (GinFuzzySearchLimit > 0)" block. Is there a particular reason why it's a good idea to do things in the current order? It almost looks like a patch application error as it stands. With either fix, I concur that we should back-patch it. It's not at all clear how come older branches don't fail because of this. regards, tom lane
В списке pgsql-bugs по дате отправления
От: Heikki Linnakangas
Дата:
От: Heikki Linnakangas
Дата: