Hi Jaime,
On 2016/11/08 2:24, Jaime Casanova wrote:
> On 7 November 2016 at 12:15, Jaime Casanova
> <jaime.casanova@2ndquadrant.com> wrote:
>> On 28 October 2016 at 02:53, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>>>
>>> Please find attached the latest version of the patches
>>
>> Hi,
>>
>> I started to review the functionality of this patch, so i applied all
>> 9 patches. After that i found this warning, which i guess is because
>> it needs a cast.
>>
>
> oh! i forgot the warning
> """
> partition.c: In function ‘get_qual_for_list’:
> partition.c:1159:6: warning: assignment from incompatible pointer type
> or = makeBoolExpr(OR_EXPR, list_make2(nulltest2, opexpr), -1);
> ^
> """
This one I noticed too and have fixed.
>
> attached a list of the warnings that my compiler give me (basically
> most are just variables that could be used uninitialized)
Thanks a lot for spotting and reporting these. Will fix as appropriate.
Regards,
Amit