Re: [PATCHES] Fixes gram.y

Поиск
Список
Период
Сортировка
Искать
От
Tom Lane
Тема
Re: [PATCHES] Fixes gram.y
Дата
Msg-id
29701.1016556884@sss.pgh.pa.us
Ответ на
Список
Дерево обсуждения
Re: [PATCHES] Fixes gram.y Fernando Nasser <fnasser@redhat.com>
Re: [PATCHES] Fixes gram.y Tom Lane <tgl@sss.pgh.pa.us>
Bruce Momjian  writes:
> Peter Eisentraut wrote:
>> There is a standard for this.  CREATE DOMAIN shows CREATE DOMAIN.

> OK, CVS changed to emit CREATE DOMAIN.

What's standard about it?  I count 9 existing statements that use
"CREATE", vs 4 that use "CREATE xxx".  (And of those four, CREATE
VERSION is dead code...)  The closest existing statement, CREATE
TYPE, emits "CREATE".

Plain "CREATE" seems like the conforming choice, unless we'd like
to do a wholesale revision of existing command tags.  Which is
not necessarily an unreasonable thing to do.  But just making CREATE
DOMAIN emit "CREATE DOMAIN" isn't improving consistency at all.

			regards, tom lane
В списке pgsql-hackers по дате отправления
От: Bruce Momjian
Дата:
Сообщение: Re: [PATCHES] Fixes gram.y
От: Bruce Momjian
Дата:
Сообщение: Re: [PATCHES] Fixes gram.y
FAQ