Re: [PATCHES] Fixes gram.y

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [PATCHES] Fixes gram.y
Дата
Msg-id 29701.1016556884@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: [PATCHES] Fixes gram.y  (Bruce Momjian <pgman@candle.pha.pa.us>)
Ответы Re: [PATCHES] Fixes gram.y  (Bruce Momjian <pgman@candle.pha.pa.us>)
Re: [PATCHES] Fixes gram.y  (Peter Eisentraut <peter_e@gmx.net>)
Список pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Peter Eisentraut wrote:
>> There is a standard for this.  CREATE DOMAIN shows CREATE DOMAIN.

> OK, CVS changed to emit CREATE DOMAIN.

What's standard about it?  I count 9 existing statements that use
"CREATE", vs 4 that use "CREATE xxx".  (And of those four, CREATE
VERSION is dead code...)  The closest existing statement, CREATE
TYPE, emits "CREATE".

Plain "CREATE" seems like the conforming choice, unless we'd like
to do a wholesale revision of existing command tags.  Which is
not necessarily an unreasonable thing to do.  But just making CREATE
DOMAIN emit "CREATE DOMAIN" isn't improving consistency at all.

            regards, tom lane

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Bruce Momjian
Дата:
Сообщение: Re: [PATCHES] Fixes gram.y
Следующее
От: Bruce Momjian
Дата:
Сообщение: Re: [PATCHES] Fixes gram.y