Re: COPYable logs
От
Tom Lane
Тема
Re: COPYable logs
Дата
Msg-id
29607.1186422127@sss.pgh.pa.us
Ответ на
Re: COPYable logs (Andrew Dunstan)
Список
Дерево обсуждения
COPYable logs Andrew Dunstan <andrew@dunslane.net>
Re: COPYable logs Tom Lane <tgl@sss.pgh.pa.us>
Re: COPYable logs Andrew Dunstan <andrew@dunslane.net>
Re: COPYable logs Andrew Dunstan <andrew@dunslane.net>
Re: COPYable logs Tom Lane <tgl@sss.pgh.pa.us>
Re: COPYable logs Andrew Dunstan <andrew@dunslane.net>
Re: COPYable logs Dave Page <dpage@postgresql.org>
Re: COPYable logs Andrew Dunstan <andrew@dunslane.net>
Andrew Dunstan writes: > I'm looking at doing #1, but I'm not sure where I can sensibly check > that redirection is on if cvslog destination is specified. I could check > when elog() is called, but that seems wasteful. Any ideas? It's only one extra bool test in elog(), isn't it? if ((Log_destination & LOG_DESTINATION_CSV) && Redirect_stderr) Hardly seems worth major contortions to avoid, considering the number of cycles an elog() call expends anyway. I thought about adding an assign-hook for Log_destination that forbids setting the CSV bit unless Redirect_stderr is set, but the trouble with that is that it's making unsupportable assumptions about the order in which the GUC variables will be set. regards, tom lane
В списке pgsql-patches по дате отправления
От: Tom Lane
Дата: