Re: Small patch modifying variable name to reflect the logic involved
От
Daniel Gustafsson
Тема
Re: Small patch modifying variable name to reflect the logic involved
Дата
Msg-id
25C2B047-66B4-4291-A26B-B42359D91A5C@yesql.se
Ответ на
Re: Small patch modifying variable name to reflect the logic involved (Daniel Gustafsson)
Список
Дерево обсуждения
Small patch modifying variable name to reflect the logic involved Krishnakumar R <kksrcv001@gmail.com>
Re: Small patch modifying variable name to reflect the logic involved Daniel Gustafsson <daniel@yesql.se>
Re: Small patch modifying variable name to reflect the logic involved Daniel Gustafsson <daniel@yesql.se>
> On 14 Sep 2023, at 11:30, Daniel Gustafsson wrote: > >> On 14 Sep 2023, at 08:28, Krishnakumar R wrote: > >> Please find a small patch to improve code readability by modifying >> variable name to reflect the logic involved - finding diff between end >> and start time of WAL sync. > > - INSTR_TIME_ACCUM_DIFF(PendingWalStats.wal_sync_time, duration, start); > + INSTR_TIME_SET_CURRENT(end); > + INSTR_TIME_ACCUM_DIFF(PendingWalStats.wal_sync_time, end, start); > > Agreed, the duration is the result of the INSTR_TIME_ACCUM_DIFF calculation, > not what's stored in the instr_time variable. And done, with a small fixup to handle another occurrence in the same file. -- Daniel Gustafsson
В списке pgsql-hackers по дате отправления