Re: Small patch: fix code duplication in heapam.c

Aleksander Alekseev <a.alekseev@postgrespro.ru> writes:
> I discovered that there is a lot of code duplication in heapam.c.
> In particular relation_openrv and relation_openrv_extended procedures
> and also heap_openrv and heap_openrv_extended procedures are almost the
> same. Here is a patch that fixes this.

As with that other patch to refactor palloc-related stuff, I'm not
convinced that this is an improvement.  All that code is hotspot stuff,
and turning it into a pile of nested procedures doesn't seem like it
improves either performance or readability.
        regards, tom lane