Re: low wal_retrieve_retry_interval causes missed signals on Windows

Поиск
Список
Период
Сортировка
Искать
От
Nathan Bossart
Тема
Re: low wal_retrieve_retry_interval causes missed signals on Windows
Дата
Msg-id
20230111232645.GA1957467@nathanxps13
Ответ на
Список
Дерево обсуждения
low wal_retrieve_retry_interval causes missed signals on Windows Nathan Bossart <nathandbossart@gmail.com>
Re: low wal_retrieve_retry_interval causes missed signals on Windows Andres Freund <andres@anarazel.de>
Re: low wal_retrieve_retry_interval causes missed signals on Windows Nathan Bossart <nathandbossart@gmail.com>
Re: low wal_retrieve_retry_interval causes missed signals on Windows Andres Freund <andres@anarazel.de>
Re: low wal_retrieve_retry_interval causes missed signals on Windows Nathan Bossart <nathandbossart@gmail.com>
On Wed, Jan 11, 2023 at 12:48:36PM -0800, Andres Freund wrote:
> Given that we check for interrupts in other parts of recovery with
> HandleStartupProcInterrupt(), which doesn't interact with latches, isn't the
> actual bug that HandleStartupProcInterrupt() doesn't contain the same black
> magic that CHECK_FOR_INTERRUPTS() contains on windows?  Namely this stuff:

Yeah, this seems like a more comprehensive fix.  I've attached a patch that
adds this Windows signaling stuff to the HandleXXXInterrupts() functions in
the files you listed.  Is this roughly what you had in mind?  If so, I'll
look around for anywhere else it is needed.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
В списке pgsql-hackers по дате отправления
От: Justin Pryzby
Дата:
От: Peter Geoghegan
Дата:
FAQ