Re: [PATCH] More docs on what to do and not do in extension code

Поиск
Список
Период
Сортировка
Искать
От
Bruce Momjian
Тема
Re: [PATCH] More docs on what to do and not do in extension code
Дата
Msg-id
20210325221549.GB18243@momjian.us
Ответ на
Список
Дерево обсуждения
[PATCH] More docs on what to do and not do in extension code Craig Ringer <craig.ringer@enterprisedb.com>
Re: [PATCH] More docs on what to do and not do in extension code Laurenz Albe <laurenz.albe@cybertec.at>
Re: [PATCH] More docs on what to do and not do in extension code Craig Ringer <craig.ringer@enterprisedb.com>
Re: [PATCH] More docs on what to do and not do in extension code Craig Ringer <craig.ringer@enterprisedb.com>
Re: [PATCH] More docs on what to do and not do in extension code Daniel Gustafsson <daniel@yesql.se>
Re: [PATCH] More docs on what to do and not do in extension code Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Re: [PATCH] More docs on what to do and not do in extension code Craig Ringer <craig.ringer@enterprisedb.com>
Re: [PATCH] More docs on what to do and not do in extension code David Steele <david@pgmasters.net>
Re: [PATCH] More docs on what to do and not do in extension code Bruce Momjian <bruce@momjian.us>
Re: [PATCH] More docs on what to do and not do in extension code Craig Ringer <craig.ringer@enterprisedb.com>
On Thu, Mar 25, 2021 at 08:49:44AM -0400, David Steele wrote:
> On 1/22/21 1:36 AM, Craig Ringer wrote:
> > 
> > Would you mind attaching a revised version of the patch with your edits?
> > Otherwise I'll go and merge them in once you've had your say on my
> > comments inline below.
> 
> Bharath, do the revisions in [1] look OK to you?
> 
> > Bruce, Robert, can I have an opinion from you on how best to locate and
> > structure these docs, or whether you think they're suitable for the main
> > docs at all? See patch upthread.
> 
> Bruce, Robert, any thoughts here?

I know I sent an email earlier this month saying we shouldn't
over-document the backend hooks because the code could drift away from
the README content:

	https://www.postgresql.org/message-id/20210309172049.GD26575%40momjian.us
	
	Agreed.  If you document the hooks too much, it allows them to drift
	away from matching the code, which makes the hook documentation actually
	worse than having no hook documentation at all.

However, for this doc patch, the content seem to be more strategic, so
less likely to change, and hard to figure out from the code directly.
Therefore, I think this would be a useful addition to the docs.

-- 
  Bruce Momjian          https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.



В списке pgsql-hackers по дате отправления
От: Bruce Momjian
Дата:
От: Markus Wanner
Дата:
FAQ