Re: [PATCH] Incremental sort (was: PoC: Partial sort)

On Fri, Mar 13, 2020 at 01:16:44PM -0400, James Coleman wrote:
>On Tue, Mar 10, 2020 at 10:44 PM Tomas Vondra
><tomas.vondra@2ndquadrant.com> wrote:
>...
>> Now, a couple comments about parts 0001 - 0003 of the patch ...
>>
>> 1) I see a bunch of failures in the regression test, due to minor
>> differences in the explain output. All the differences are about minor
>> changes in memory usage, like this:
>>
>> -               "Sort Space Used": 30,                             +
>> +               "Sort Space Used": 29,                             +
>>
>> I'm not sure if it happens on my machine only, but maybe the test is not
>> entirely stable.
>
>make check passes on multiple machines for me; what arch/distro are you using?
>

Nothing exotic - Fedora on x64. My guess is that things like enabling
asserts will make a difference too, because then we track additional
stuff for allocated chunks etc. So I agree with Tom trying to keep this
stable is a lost cause, essentially.


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services