Re: [PATCH] Find additional connection service files inpg_service.conf.d directory

Поиск
Список
Период
Сортировка
От Arthur Zakirov
Тема Re: [PATCH] Find additional connection service files inpg_service.conf.d directory
Дата
Msg-id 20180618161712.GA2086@zakirov.localdomain
обсуждение исходный текст
Ответ на Re: [PATCH] Find additional connection service files inpg_service.conf.d directory  (Curt Tilmes <curt@tilmes.org>)
Ответы Re: [PATCH] Find additional connection service files inpg_service.conf.d directory  (Michael Paquier <michael@paquier.xyz>)
Re: [PATCH] Find additional connection service files inpg_service.conf.d directory  (Curt Tilmes <curt@tilmes.org>)
Список pgsql-hackers
Hello,

On Thu, Mar 01, 2018 at 01:40:10PM -0500, Curt Tilmes wrote:
> New patch limits files to ".conf".

Isn't it worth to check errno for stat(), opendir() and readdir() calls?

I think when some error occured in searchServiceFileDirectory() then the
error "definition of service \"%s\" not found" will be raised, because
group_found is false. It may confuse as it hides a real error. For
example, if permission is denied to open the directory.

-- 
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: Server crashed with TRAP: FailedAssertion("!(parallel_workers >0)" when partitionwise_aggregate true.
Следующее
От: Tomas Vondra
Дата:
Сообщение: Re: [Proposal] Table-level Transparent Data Encryption (TDE) and KeyManagement Service (KMS)