Re: [HACKERS] Help text for pg_basebackup -R
От
Alvaro Herrera
Тема
Re: [HACKERS] Help text for pg_basebackup -R
Дата
Msg-id
20170217133717.qpipj5i37ehfygcw@alvherre.pgsql
Ответ на
Re: [HACKERS] Help text for pg_basebackup -R (Magnus Hagander)
Список
Дерево обсуждения
[HACKERS] Help text for pg_basebackup -R Magnus Hagander <magnus@hagander.net>
Re: [HACKERS] Help text for pg_basebackup -R Alvaro Herrera <alvherre@2ndquadrant.com>
Re: [HACKERS] Help text for pg_basebackup -R Magnus Hagander <magnus@hagander.net>
Re: [HACKERS] Help text for pg_basebackup -R Alvaro Herrera <alvherre@2ndquadrant.com>
Re: [HACKERS] Help text for pg_basebackup -R Stephen Frost <sfrost@snowman.net>
Re: [HACKERS] Help text for pg_basebackup -R Tom Lane <tgl@sss.pgh.pa.us>
Re: [HACKERS] Help text for pg_basebackup -R Magnus Hagander <magnus@hagander.net>
Magnus Hagander wrote:
> On Wednesday, February 15, 2017, Alvaro Herrera
> wrote:
>
> > Magnus Hagander wrote:
> >
> > > printf(_(" -R, --write-recovery-conf\n"
> > > - " write recovery.conf
> > after backup\n"));
> > > + " write recovery.conf for
> > replication\n"));
> > > printf(_(" -S, --slot=SLOTNAME replication slot to use\n"));
> >
> > LGTM.
> >
> I'm guessing if we backpatch something like that, it would cause issues for
> translations, right? So we should make it head only?
We've had the argument a number of times. My stand is that many
translators are active in the older branches, so this update would be
caught there too; and even if not, an updated English message is better
than an outdated native-language message.
Now, that's been argued in the context of a bug fix that introduces new
messages or changed an existing message for other reasons. I'm not sure
how strongly do we think it applies for a change that's *only* about
updating a message. I'm +0.5 on back-patching the change in this case.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
В списке pgsql-hackers по дате отправления
От: Stephen Frost
Дата: