Re: uninitialized values in revised prepared xact code

On 2014-10-24 17:13:49 +0300, Heikki Linnakangas wrote:
> Yeah. The padding bytes in TwoPhaseFileHeader were not initialized.
> 
> That's simple enough to fix, but when I run valgrind, I get a lot whole
> bunch of similar messages. A few are from pgstat: the padding bytes in the
> pgstat messages are not initialized. One comes from
> write_relcache_init_file(); again I believe it's padding bytes being
> uninitialized (in FormData_pg_attribute). And one from the XLogInsert from
> heap_insert; there's an uninitialized padding byte in xl_heap_insert. And so
> forth.. Is it worthwhile to hunt down all of these? If there aren't many
> more than these, it probably is worth it, but I fear this might be an
> endless effort. Have we been clean of these warnings at any point in the
> past?

Did you use the valgrind suppression file in src/tools? It suppresses
some "known harmless" cases.

Greetings,

Andres Freund

-- Andres Freund	                   http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services