Re: Triggers on columns

Peter Eisentraut  wrote:

> What is the purpose of the new pg_get_triggerdef() variant?  OK, the
> parameter name "pretty_bool" gives a hint, but what does this have to do
> with column triggers?  Maybe you could try to explain this in more
> detail.  Ideally split the patch into two: one that deals with
> pg_get_triggerdef(), and one that deals with column triggers.

It's for pg_dump. We can avoid duplicated codes if we use
pg_get_triggerdef() in pg_dump. So, I think column trigger and
the dump function for column trigger should be applied at once.

> If you want a "pretty" option on pg_get_triggerdef(), you could nowadays
> also implement that via a parameter default value instead of a second
> function.

OK, I'll rewrite it to use default parameter.

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center