> > Tatsuo, would you please comment on this patch?
>
> Sure. I will come up with a comment by the end of this week.
The patches look good to me.
BTW, is anybody working on enabling the fill factor to the tables used
by pgbench? 8.3 will introduce HOT, and I think adding the feature
will make it easier to test HOT.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
> > ---------------------------------------------------------------------------
> >
> > ITAGAKI Takahiro wrote:
> > > The attached is a patch to optimize contrib/pgbench using new 8.3 features.
> > >
> > > - Use DROP IF EXISTS to suppress errors for initial loadings.
> > > - Use a combination of TRUNCATE and COPY to reduce WAL on creating
> > > the accounts table.
> > >
> > > Also, there are some cosmetic changes.
> > >
> > > - Change the output of -v option from "starting full vacuum..."
> > > to "starting vacuum accounts..." in reflection of the fact.
> > > - Shape duplicated error checks into executeStatement().
> > >
> > >
> > > There is a big performance win in "COPY with no WAL" feature.
> > > Thanks for the efforts!
> > >
> > > Regards,
> > > ---
> > > ITAGAKI Takahiro
> > > NTT Open Source Software Center
> >
> > [ Attachment, skipping... ]
> >
> > >
> > > ---------------------------(end of broadcast)---------------------------
> > > TIP 5: don't forget to increase your free space map settings
> >
> > --
> > Bruce Momjian <bruce@momjian.us> http://momjian.us
> > EnterpriseDB http://www.enterprisedb.com
> >
> > + If your life is a hard drive, Christ can be your backup. +