Re: [PATCHES] thousands comma numeric formatting in psql

Tom Lane wrote:
> Bruce Momjian  writes:
> > Tom Lane wrote:
> >> This patch sounds quite a lot different from what I thought we had
> >> agreed to, which was a way to specify that the client-side LC_NUMERIC
> >> locale settings should be used for formatting numbers.  I think the only
> >> pset should be "locale on" or "locale not on".  This business about
> >> space is a red herring: if you want that, create a locale spec that
> >> specifies it.
> 
> > Well, how many people have langinfo?  I don't.
> 
> What's langinfo got to do with it?  To minimize our portability
> exposure, the patch should use the same facilities that
> src/backend/utils/adt/pg_locale.c already depends on, namely
> setlocale() and localeconv().

The original patch included "langinfo.h" and used this call to set the
default separator:
char *dec_point = nl_langinfo(__DECIMAL_POINT);

I don't see __DECIMAL_POINT defined anywhere on the FreeBSD 4.11 box we
use for CVS.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610) 359-1001 +  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073