Re: pgsql/src backend/catalog/index.c backend/pars ...
От
Bruce Momjian
Тема
Re: pgsql/src backend/catalog/index.c backend/pars ...
Дата
Msg-id
200105182255.f4IMtv115675@candle.pha.pa.us
Ответ на
Список
Дерево обсуждения
pgsql/src backend/catalog/index.c backend/pars ... Bruce Momjian - CVS <momjian@hub.org>
Re: pgsql/src backend/catalog/index.c backend/pars ... Tom Lane <tgl@sss.pgh.pa.us>
Re: pgsql/src backend/catalog/index.c backend/pars ... Bruce Momjian <pgman@candle.pha.pa.us>
Re: pgsql/src backend/catalog/index.c backend/pars ... Tom Lane <tgl@sss.pgh.pa.us>
Re: pgsql/src backend/catalog/index.c backend/pars ... Bruce Momjian <pgman@candle.pha.pa.us>
> Bruce Momjian - CVS writes: > > Rename ParseFuncOrColumn() to ParseColumnOrFunc(). > > This is an improvement? > > Considering that the function is primarily concerned with parsing > function calls, I'd call this a net decrease in intelligibility. Here is my comment added to the top of the code. Is it correct? /* * parse function * This code is confusing code because the database can accept * relation.column, column.function, or relation.column.function. * It can also be called as func(col) or func(col,col). * * Funcname is the first parameter, and fargs are the rest. */ ParseColumnOrFunc(ParseState *pstate, char *funcname, List *fargs, bool agg_star, bool agg_distinct, int precedence) -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
В списке pgsql-committers по дате отправления
От: Bruce Momjian - CVS
Дата: