Re: type cache cleanup improvements
От
Жарков Роман
Тема
Re: type cache cleanup improvements
Дата
Msg-id
1d01a3-66064880-1-7cb74a00@198342865
Ответ на
Re: type cache cleanup improvements (Teodor Sigaev)
Список
Дерево обсуждения
type cache cleanup improvements Teodor Sigaev <teodor@sigaev.ru>
Re: type cache cleanup improvements Aleksander Alekseev <aleksander@timescale.com>
Re: type cache cleanup improvements Teodor Sigaev <teodor@sigaev.ru>
Re: type cache cleanup improvements Aleksander Alekseev <aleksander@timescale.com>
Re: type cache cleanup improvements Teodor Sigaev <teodor@sigaev.ru>
Re: type cache cleanup improvements Aleksander Alekseev <aleksander@timescale.com>
Re: type cache cleanup improvements Tom Lane <tgl@sss.pgh.pa.us>
Re: type cache cleanup improvements Teodor Sigaev <teodor@sigaev.ru>
Re: type cache cleanup improvements Aleksander Alekseev <aleksander@timescale.com>
Re: type cache cleanup improvements Teodor Sigaev <teodor@sigaev.ru>
Re: type cache cleanup improvements Michael Paquier <michael@paquier.xyz>
Re: type cache cleanup improvements Teodor Sigaev <teodor@sigaev.ru>
Re: type cache cleanup improvements Michael Paquier <michael@paquier.xyz>
Re: type cache cleanup improvements Teodor Sigaev <teodor@sigaev.ru>
Re: type cache cleanup improvements Michael Paquier <michael@paquier.xyz>
Re: type cache cleanup improvements Teodor Sigaev <teodor@sigaev.ru>
Re: type cache cleanup improvements Жарков Роман <r.zharkov@postgrespro.ru>
Re: type cache cleanup improvements Andrei Lepikhov <a.lepikhov@postgrespro.ru>
Re: type cache cleanup improvements Alexander Korotkov <aekorotkov@gmail.com>
> Rest of patches, rebased.
Hello,
I read and tested only the first patch so far. Creation of temp
tables and rollback in your script work 3-4 times faster with
0001-type-cache.patch on my windows laptop.
In the patch I found a copy of the comment "If it's domain over
composite, reset flags...". Can we move the reset flags operation
and its comment into the invalidateCompositeTypeCacheEntry()
function? This simplify the TypeCacheRelCallback() func, but
adds two more IF statements when we need to clean up a cache
entry for a specific relation. (diff attached).
--
Roman Zharkov
Hello,
I read and tested only the first patch so far. Creation of temp
tables and rollback in your script work 3-4 times faster with
0001-type-cache.patch on my windows laptop.
In the patch I found a copy of the comment "If it's domain over
composite, reset flags...". Can we move the reset flags operation
and its comment into the invalidateCompositeTypeCacheEntry()
function? This simplify the TypeCacheRelCallback() func, but
adds two more IF statements when we need to clean up a cache
entry for a specific relation. (diff attached).
--
Roman Zharkov
В списке pgsql-hackers по дате отправления
От: Melanie Plageman
Дата:
