Re: BUG #1671: Long interval string representation rejected

Поиск
Список
Период
Сортировка
Искать
От
Tom Lane
Тема
Re: BUG #1671: Long interval string representation rejected
Дата
в 03:04:10
Msg-id
17757.1116396246@sss.pgh.pa.us
Ответ на
Список
Дерево обсуждения
BUG #1671: Long interval string representation rejected "Mark Dilger" <markdilger@yahoo.com>
Re: BUG #1671: Long interval string representation rejected Neil Conway <neilc@samurai.com>
Re: BUG #1671: Long interval string representation rejected Tom Lane <tgl@sss.pgh.pa.us>
Re: BUG #1671: Long interval string representation rejected Neil Conway <neilc@samurai.com>
Re: BUG #1671: Long interval string representation rejected Tom Lane <tgl@sss.pgh.pa.us>
Re: BUG #1671: Long interval string representation rejected Neil Conway <neilc@samurai.com>
Re: BUG #1671: Long interval string representation rejected Tom Lane <tgl@sss.pgh.pa.us>
Re: BUG #1671: Long interval string representation rejected Neil Conway <neilc@samurai.com>
Re: BUG #1671: Long interval string representation rejected Tom Lane <tgl@sss.pgh.pa.us>
Re: BUG #1671: Long interval string representation rejected Neil Conway <neilc@samurai.com>
Re: BUG #1671: Long interval string representation rejected Tom Lane <tgl@sss.pgh.pa.us>
Re: BUG #1671: Long interval string representation rejected Neil Conway <neilc@samurai.com>
Re: BUG #1671: Long interval string representation rejected Neil Conway <neilc@samurai.com>
Re: BUG #1671: Long interval string representation rejected Tom Lane <tgl@sss.pgh.pa.us>
Re: BUG #1671: Long interval string representation rejected Neil Conway <neilc@samurai.com>
Re: BUG #1671: Long interval string representation rejected Tom Lane <tgl@sss.pgh.pa.us>
Re: BUG #1671: Long interval string representation rejected Tom Lane <tgl@sss.pgh.pa.us>
Re: BUG #1671: Long interval string representation rejected Neil Conway <neilc@samurai.com>
Re: BUG #1671: Long interval string representation rejected Neil Conway <neilc@samurai.com>
Neil Conway  writes:
> Yeah, this seems bogus. It's not even clear to me why MAXDATELEN + 
> MAXDATEFIELDS is used as the size of that buffer in the first place. I 
> don't know the datetime code particularly well; perhaps someone who does 
> can shed some light on this?

My rule of thumb with the datetime code is that if it looks bogus,
it probably is :-(

There are a lot of fixed-size local buffers in that code.  The ones
used in output routines seem defensible since the string to be generated
is predictable.  The ones that are used for processing input are likely
wrong.  OTOH I'm not eager to throw a palloc into each of those code
paths ... can we avoid that?

			regards, tom lane
В списке pgsql-bugs по дате отправления
От: Neil Conway
Дата:
От: Michael Fuhr
Дата:
FAQ