Re: WAL format and API changes (9.5)

Andres Freund <andres@2ndquadrant.com> writes:
> On 2014-04-03 19:08:27 -0400, Tom Lane wrote:
>> A somewhat more relevant concern is where are we going to keep the state
>> data involved in all this.  Since this code is, by definition, going to be
>> called in critical sections, any solution involving internal pallocs is
>> right out.

> We actually already allocate memory in XLogInsert() :(, although only in
> the first XLogInsert() a backend does...

Ouch.  I wonder if we should put an Assert(not-in-critical-section)
into MemoryContextAlloc.
        regards, tom lane