Re: Fix typo about WalSndPrepareWrite

Поиск
Список
Период
Сортировка
Искать
От
Cary Huang
Тема
Re: Fix typo about WalSndPrepareWrite
Дата
Msg-id
161358563718.24325.3410339738199469749.pgcf@coridan.postgresql.org
Ответ на
Список
Дерево обсуждения
Fix typo about WalSndPrepareWrite japin <japinli@hotmail.com>
Re: Fix typo about WalSndPrepareWrite Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Re: Fix typo about WalSndPrepareWrite Li Japin <japinli@hotmail.com>
Re: Fix typo about WalSndPrepareWrite Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Re: Fix typo about WalSndPrepareWrite japin <japinli@hotmail.com>
Re: Fix typo about WalSndPrepareWrite Cary Huang <cary.huang@highgo.ca>
Re: Fix typo about WalSndPrepareWrite japin <japinli@hotmail.com>
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, passed

Hi,

thanks for the patch, however I don't think it is a typo. The comment indicates a technique that is used throughout many functions in walsender.c, which is to fill the send-timestamp as late as possible so it is more accurate. This is done by first reserving a spot in the write stream, write the actual data, and then finally write the current timestamp to the reserved spot. This technique is used in WalSndWriteData() and also XLogSendPhysical()... so really it doesn't matter which function name to put in the comment.

thank you!

-----------
Cary Huang
HighGo Software (Canada)
В списке pgsql-hackers по дате отправления
От: Tom Lane
Дата:
От: Jacob Champion
Дата:
FAQ