Re: log_rotation_age integer overflow display quirk

Поиск
Список
Период
Сортировка
Искать
От
Tom Lane
Тема
Re: log_rotation_age integer overflow display quirk
Дата
Msg-id
14536.1215373802@sss.pgh.pa.us
Ответ на
Список
Дерево обсуждения
log_rotation_age integer overflow display quirk Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>
Re: log_rotation_age integer overflow display quirk Bernd Helmle <mailings@oopsware.de>
Re: log_rotation_age integer overflow display quirk Tom Lane <tgl@sss.pgh.pa.us>
Bernd Helmle  writes:
> --On Freitag, Juli 04, 2008 11:31:07 +0200 Stefan Kaltenbrunner 
>  wrote:
>> I just noticed that setting log_rotation_age to a value larger than 24
>> days results in rather weird output (I have not actually tested yet if
>> that affects the functionality too or just the output):

> This seems to be a bug in _ShowOption(), where the corresponding value is 
> converted into milliseconds to get the biggest possible time unit to 
> display. This overflows the result variable (which is declared as int), 
> causing this strange output.

Yup --- fixed by using int64 arithmetic for the units conversion.
		regards, tom lane

В списке pgsql-hackers по дате отправления
От: Dean Rasheed
Дата:
Сообщение: Re: Auto-explain patch
От: Tom Lane
Дата:
FAQ