Re: [BUG]Invalidate relcache when setting REPLICA IDENTITY
От
Euler Taveira
Тема
Re: [BUG]Invalidate relcache when setting REPLICA IDENTITY
Дата
Msg-id
0fe01530-78b1-4cbf-8af8-99f01667fe5e@www.fastmail.com
Ответ на
RE: [BUG]Invalidate relcache when setting REPLICA IDENTITY (houzj.fnst@fujitsu.com)
Список
Дерево обсуждения
[BUG]Invalidate relcache when setting REPLICA IDENTITY "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>
Re: [BUG]Invalidate relcache when setting REPLICA IDENTITY Amit Kapila <amit.kapila16@gmail.com>
RE: [BUG]Invalidate relcache when setting REPLICA IDENTITY "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
Re: [BUG]Invalidate relcache when setting REPLICA IDENTITY Amit Kapila <amit.kapila16@gmail.com>
Re: [BUG]Invalidate relcache when setting REPLICA IDENTITY Amit Kapila <amit.kapila16@gmail.com>
RE: [BUG]Invalidate relcache when setting REPLICA IDENTITY "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
RE: [BUG]Invalidate relcache when setting REPLICA IDENTITY "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
Re: [BUG]Invalidate relcache when setting REPLICA IDENTITY "Euler Taveira" <euler@eulerto.com>
RE: [BUG]Invalidate relcache when setting REPLICA IDENTITY "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
RE: [BUG]Invalidate relcache when setting REPLICA IDENTITY "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
Re: [BUG]Invalidate relcache when setting REPLICA IDENTITY Amit Kapila <amit.kapila16@gmail.com>
Re: [BUG]Invalidate relcache when setting REPLICA IDENTITY Amit Kapila <amit.kapila16@gmail.com>
RE: [BUG]Invalidate relcache when setting REPLICA IDENTITY "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
Re: [BUG]Invalidate relcache when setting REPLICA IDENTITY "Euler Taveira" <euler@eulerto.com>
Re: [BUG]Invalidate relcache when setting REPLICA IDENTITY Amit Kapila <amit.kapila16@gmail.com>
RE: [BUG]Invalidate relcache when setting REPLICA IDENTITY "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
Re: [BUG]Invalidate relcache when setting REPLICA IDENTITY Amit Kapila <amit.kapila16@gmail.com>
On Thu, Nov 11, 2021, at 9:01 AM, houzj.fnst@fujitsu.com wrote:
Also attach the patches for back branch and remove some unnecessarychanges from pgindent.
I reviewed your patch and I think the fix could be simplified by
if (OidIsValid(indexOid))
CacheInvalidateRelcache(rel);
If indexOid is valid it is a REPLICA IDENTITY INDEX. A few lines above there is
a check for a valid indexOid that makes sure the index is already marked as a
replica identity; if so, it bail out. If it is not, the relation should be
invalidated. Am I missing something?
I also modified your test case to include a DELETE command, wait the initial
table sync to avoid failing a subsequent test and improve some comments.
В списке pgsql-hackers по дате отправления
