Re: encode/decode support for base64url
От
Florents Tselai
Тема
Re: encode/decode support for base64url
Дата
Msg-id
0F9CC1F5-2CEA-4CA1-9711-43C88E32F796@gmail.com
Ответ на
Re: encode/decode support for base64url (Aleksander Alekseev)
Список
Дерево обсуждения
encode/decode support for base64url Przemysław Sztoch <przemyslaw@sztoch.pl>
Re: encode/decode support for base64url Daniel Gustafsson <daniel@yesql.se>
Re: encode/decode support for base64url Aleksander Alekseev <aleksander@timescale.com>
Re: encode/decode support for base64url Florents Tselai <florents.tselai@gmail.com>
Re: encode/decode support for base64url Florents Tselai <florents.tselai@gmail.com>
Re: encode/decode support for base64url Daniel Gustafsson <daniel@yesql.se>
Re: encode/decode support for base64url Florents Tselai <florents.tselai@gmail.com>
Re: encode/decode support for base64url Cary Huang <cary.huang@highgo.ca>
Re: encode/decode support for base64url Florents Tselai <florents.tselai@gmail.com>
Re: encode/decode support for base64url Florents Tselai <florents.tselai@gmail.com>
Re: encode/decode support for base64url Aleksander Alekseev <aleksander@timescale.com>
Re: encode/decode support for base64url Florents Tselai <florents.tselai@gmail.com>
Re: encode/decode support for base64url Aleksander Alekseev <aleksander@tigerdata.com>
Re: encode/decode support for base64url Florents Tselai <florents.tselai@gmail.com>
Re: encode/decode support for base64url "David E. Wheeler" <david@justatheory.com>
Re: encode/decode support for base64url Florents Tselai <florents.tselai@gmail.com>
Re: encode/decode support for base64url "David E. Wheeler" <david@justatheory.com>
Re: encode/decode support for base64url Florents Tselai <florents.tselai@gmail.com>
Re: encode/decode support for base64url "David E. Wheeler" <david@justatheory.com>
Re: encode/decode support for base64url Daniel Gustafsson <daniel@yesql.se>
Re: encode/decode support for base64url "David E. Wheeler" <david@justatheory.com>
Re: encode/decode support for base64url Florents Tselai <florents.tselai@gmail.com>
Re: encode/decode support for base64url Florents Tselai <florents.tselai@gmail.com>
Re: encode/decode support for base64url Florents Tselai <florents.tselai@gmail.com>
Re: encode/decode support for base64url Florents Tselai <florents.tselai@gmail.com>
Re: encode/decode support for base64url Masahiko Sawada <sawada.mshk@gmail.com>
Re: encode/decode support for base64url Florents Tselai <florents.tselai@gmail.com>
Re: encode/decode support for base64url Masahiko Sawada <sawada.mshk@gmail.com>
Re: encode/decode support for base64url Daniel Gustafsson <daniel@yesql.se>
Re: encode/decode support for base64url Daniel Gustafsson <daniel@yesql.se>
Re: encode/decode support for base64url Daniel Gustafsson <daniel@yesql.se>
Re: encode/decode support for base64url Daniel Gustafsson <daniel@yesql.se>
Re: encode/decode support for base64url Chao Li <li.evan.chao@gmail.com>
Re: encode/decode support for base64url Florents Tselai <florents.tselai@gmail.com>
Re: encode/decode support for base64url Chao Li <li.evan.chao@gmail.com>
Re: encode/decode support for base64url Daniel Gustafsson <daniel@yesql.se>
Re: encode/decode support for base64url Daniel Gustafsson <daniel@yesql.se>
Re: encode/decode support for base64url Przemysław Sztoch <przemyslaw@sztoch.pl>
Re: encode/decode support for base64url Pavel Seleznev <pavel.seleznev@gmail.com>
Thanks for the review Aleksander,
> On 9 Jul 2025, at 10:45 PM, Aleksander Alekseev wrote:
>
> Hi Florents,
>
> Thanks for the update!
>
>> here's a v4 patch set
>>
>> - Extracted pg_base64_{en,de}_internal with an additional bool url param, to be used by other functions
>> - Added a few more test cases
>>
>> Cary mentioned above
>>
>>> In addition, you may also want to add the C versions of base64rul encode
>> and decode functions to "src/common/base64.c" as new API calls
>>
>> Haven't done that, but I could;
>> Although I think it'd probably be best to do it in a separate patch.
>
> I reviewed and tested v4. To me it looks as good as it will get.
> Personally I would change a few minor things here and there and
> probably merge all three patches into a single commit. This however is
> up to the committer to decide.
Attaching a single-file patch
>
> Changing the CF entry status to "RfC".
В списке pgsql-hackers по дате отправления
От: Amit Kapila
Дата: