On Fri, Feb 11, 2011 at 10:31:08AM -0600, Kevin Grittner wrote:
> Robert Haas <robertmhaas@gmail.com> wrote:
> > Noah Misch <noah@leadboat.com> wrote:
> >> From a functional and code structure perspective, I find this
> >> ready to commit. (I assume you'll drop the XXX: indent only
> >> comments on commit.) Kevin, did you want to do that performance
> >> testing you spoke of?
> >
> > OK, so is this Ready for Committer, or we're still working on it?
>
> I can run some benchmarks to compare COPY statements with and
> without the patch this weekend. Noah, does it make more sense to do
> that with just the copy_export-20110209.patch patch file applied, or
> in combination with some other FDW patch(es)?
I'd say, run them with this patch alone. The important thing is to not penalize
existing COPY users. Incidentally, the "did you want ... ?" was a genuine
question. I see very little performance risk here, so the tests could be quite
cursory, even absent entirely.
nm