Re: Temporary WAL segments files not cleaned up after an instancecrash

Поиск
Список
Период
Сортировка
От Heikki Linnakangas
Тема Re: Temporary WAL segments files not cleaned up after an instancecrash
Дата
Msg-id f93fd0a2-6cc2-978f-7a3b-5f34a7d9bc0c@iki.fi
обсуждение исходный текст
Ответ на Re: Temporary WAL segments files not cleaned up after an instancecrash  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: Temporary WAL segments files not cleaned up after an instancecrash  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
Дерево обсуждения 
On 12/07/18 15:38, Michael Paquier wrote:
> On Thu, Jul 12, 2018 at 01:15:03PM +0300, Heikki Linnakangas wrote:
>> On 12/07/18 10:44, Michael Paquier wrote:
>>> +        snprintf(path, MAXPGPATH, XLOGDIR "/%s", xlde->d_name);
>>> +        elog(DEBUG2, "removed temporary WAL file \"%s\"", path);
>>> +        unlink(path);
>>
>> The elog message says "removed", but the removal actually happens after the
>> elog. "removing" would be more accurate.
> 
> Or just move the elog() after the file is actually removed?  Would you
> be fine with that?

Sure.

- Heikki

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Temporary WAL segments files not cleaned up after an instancecrash
Следующее
От: Ashutosh Bapat
Дата:
Сообщение: Re: partition pruning doesn't work with IS NULL clause in multikeyrange partition case