Re: row filtering for logical replication
От
Euler Taveira
Тема
Re: row filtering for logical replication
Дата
Msg-id
ef6295fa-678b-41bd-b2a8-50497dc95cb9@www.fastmail.com
Ответ на
Re: row filtering for logical replication (Amit Kapila)
Список
Дерево обсуждения
row filtering for logical replication Euler Taveira <euler@timbira.com.br>
Re: row filtering for logical replication David Fetter <david@fetter.org>
Re: row filtering for logical replication Euler Taveira <euler@timbira.com.br>
Re: row filtering for logical replication David Fetter <david@fetter.org>
Re: row filtering for logical replication Erik Rijkers <er@xs4all.nl>
Re: row filtering for logical replication Andres Freund <andres@anarazel.de>
Re: row filtering for logical replication David Steele <david@pgmasters.net>
Re: row filtering for logical replication Euler Taveira <euler@timbira.com.br>
Re: row filtering for logical replication David Steele <david@pgmasters.net>
Re: row filtering for logical replication Michael Paquier <michael@paquier.xyz>
Re: row filtering for logical replication Erik Rijkers <er@xs4all.nl>
Re: row filtering for logical replication Euler Taveira <euler@timbira.com.br>
Re: row filtering for logical replication Euler Taveira <euler@timbira.com.br>
Re: row filtering for logical replication Erik Rijkers <er@xs4all.nl>
Re: row filtering for logical replication Erik Rijkers <er@xs4all.nl>
Re: row filtering for logical replication Euler Taveira <euler@timbira.com.br>
Re: row filtering for logical replication Erik Rijkers <er@xs4all.nl>
Re: row filtering for logical replication Petr Jelinek <petr.jelinek@2ndquadrant.com>
Re: row filtering for logical replication David Fetter <david@fetter.org>
Re: row filtering for logical replication Petr Jelinek <petr.jelinek@2ndquadrant.com>
Re: row filtering for logical replication Euler Taveira <euler@timbira.com.br>
Re: row filtering for logical replication Alvaro Herrera <alvherre@2ndquadrant.com>
Re: row filtering for logical replication Andres Freund <andres@anarazel.de>
Re: row filtering for logical replication a.kondratov@postgrespro.ru
Re: row filtering for logical replication Euler Taveira <euler@timbira.com.br>
Re: row filtering for logical replication Alexey Zagarin <zagarin@gmail.com>
Re: row filtering for logical replication Euler Taveira <euler@timbira.com.br>
Re: row filtering for logical replication Erik Rijkers <er@xs4all.nl>
Re: row filtering for logical replication Euler Taveira <euler@timbira.com.br>
Re: row filtering for logical replication Erik Rijkers <er@xs4all.nl>
Re: row filtering for logical replication Alexey Zagarin <zagarin@gmail.com>
Re: row filtering for logical replication Euler Taveira <euler@timbira.com.br>
Re: row filtering for logical replication Erik Rijkers <er@xs4all.nl>
Re: row filtering for logical replication Alexey Zagarin <zagarin@gmail.com>
Re: row filtering for logical replication Euler Taveira <euler@timbira.com.br>
Re: row filtering for logical replication movead li <movead.li@highgo.ca>
Re: row filtering for logical replication Euler Taveira <euler@timbira.com.br>
Re: row filtering for logical replication Euler Taveira <euler@timbira.com.br>
Re: row filtering for logical replication Amit Langote <amitlangote09@gmail.com>
Re: row filtering for logical replication Amit Langote <amitlangote09@gmail.com>
Re: row filtering for logical replication Michael Paquier <michael@paquier.xyz>
Re: row filtering for logical replication Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: row filtering for logical replication Euler Taveira <euler@timbira.com.br>
Re: row filtering for logical replication Craig Ringer <craig@2ndquadrant.com>
Re: row filtering for logical replication David Steele <david@pgmasters.net>
Re: row filtering for logical replication David Steele <david@pgmasters.net>
Re: row filtering for logical replication "Euler Taveira" <euler@eulerto.com>
Re: row filtering for logical replication japin <japinli@hotmail.com>
Re: row filtering for logical replication "Euler Taveira" <euler@eulerto.com>
Re: row filtering for logical replication japin <japinli@hotmail.com>
Re: row filtering for logical replication Michael Paquier <michael@paquier.xyz>
Re: row filtering for logical replication japin <japinli@hotmail.com>
Re: row filtering for logical replication japin <japinli@hotmail.com>
Re: row filtering for logical replication "Euler Taveira" <euler@eulerto.com>
Re: row filtering for logical replication Önder Kalacı <onderkalaci@gmail.com>
Re: row filtering for logical replication Andres Freund <andres@anarazel.de>
Re: row filtering for logical replication Masahiko Sawada <sawada.mshk@gmail.com>
Re: row filtering for logical replication Önder Kalacı <onderkalaci@gmail.com>
Re: row filtering for logical replication Petr Jelinek <petr.jelinek@2ndquadrant.com>
Re: row filtering for logical replication Fabrízio de Royes Mello <fabriziomello@gmail.com>
Re: row filtering for logical replication Petr Jelinek <petr.jelinek@2ndquadrant.com>
Re: row filtering for logical replication Fabrízio de Royes Mello <fabriziomello@gmail.com>
Re: row filtering for logical replication Stephen Frost <sfrost@snowman.net>
Re: row filtering for logical replication Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: row filtering for logical replication Stephen Frost <sfrost@snowman.net>
Re: row filtering for logical replication Petr Jelinek <petr.jelinek@2ndquadrant.com>
Re: row filtering for logical replication Stephen Frost <sfrost@snowman.net>
Re: row filtering for logical replication Petr Jelinek <petr.jelinek@2ndquadrant.com>
Re: row filtering for logical replication Petr Jelinek <petr.jelinek@2ndquadrant.com>
Re: row filtering for logical replication Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: row filtering for logical replication Hironobu SUZUKI <hironobu@interdb.jp>
Re: row filtering for logical replication Craig Ringer <craig@2ndquadrant.com>
Re: row filtering for logical replication Euler Taveira <euler@timbira.com.br>
Re: row filtering for logical replication Stephen Frost <sfrost@snowman.net>
Re: row filtering for logical replication Petr Jelinek <petr.jelinek@2ndquadrant.com>
Re: row filtering for logical replication Euler Taveira <euler@timbira.com.br>
Re: row filtering for logical replication Stephen Frost <sfrost@snowman.net>
Re: row filtering for logical replication Petr Jelinek <petr.jelinek@2ndquadrant.com>
Re: row filtering for logical replication Stephen Frost <sfrost@snowman.net>
Re: row filtering for logical replication Petr Jelinek <petr.jelinek@2ndquadrant.com>
On Thu, Jan 6, 2022, at 1:18 AM, Amit Kapila wrote:
On Thu, Jan 6, 2022 at 8:43 AM Peter Smith <smithpb2250@gmail.com> wrote:>> On Wed, Jan 5, 2022 at 9:52 PM Amit Kapila <amit.kapila16@gmail.com> wrote:> >> ...>> > Another minor comment:> > +static bool pgoutput_row_filter(enum ReorderBufferChangeType changetype,> >> > Do we need to specify the 'enum' type before changetype parameter?> >>> That is because there is currently no typedef for the enum> ReorderBufferChangeType.>But I see that the 0002 patch is already adding the required typedef.
IMO we shouldn't reuse ReorderBufferChangeType. For a long-term solution, it is
fragile. ReorderBufferChangeType has values that do not matter for row filter
and it relies on the fact that REORDER_BUFFER_CHANGE_INSERT,
REORDER_BUFFER_CHANGE_UPDATE and REORDER_BUFFER_CHANGE_DELETE are the first 3
values from the enum, otherwise, it breaks rfnodes and no_filters in
pgoutput_row_filter(). I suggest a separate enum that contains only these 3
values.
enum RowFilterPublishAction {
PUBLISH_ACTION_INSERT,
PUBLISH_ACTION_UPDATE,
PUBLISH_ACTION_DELETE
};
В списке pgsql-hackers по дате отправления