Two more thoughts:
- Add some tests. The if (nBufferedTuples > 0) that flushes the tuples
when the partition changes is not currently exercised.
- With proute becoming a function-level variable,
cstate->partition_tuple_routing is obsolete and could be removed. (No
point in saving this in cstate if it's only used in one function anyway.)
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services