Re: [Refactor]Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO

Поиск

Список

Период

Сортировка

От	Zhang Mingli
Тема	Re: [Refactor]Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO
Дата	2 августа 2022 г. 11:13:30
Msg-id	cdf7a67c-3f5e-4ce7-86db-151f86e27d8a@Spark обсуждение исходный текст
Ответ на	Re: [Refactor]Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Ответы	Re: [Refactor]Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO (Michael Paquier <michael@paquier.xyz>)
Список	pgsql-hackers

Дерево обсуждения

Regards,

Zhang Mingli

On Aug 2, 2022, 12:30 +0800, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, wrote:

An empty List is not NULL but NIL (which values are identical,
though).

Thanks for pointing that out. Fix it in new patch.

There are some other option combinations that are rejected
by ProcessCopyOptions. On the other hand *re*checking all
combinations that the function should have rejected is kind of silly.
Addition to that, I doubt the assertions are really needed even though
the wrong values don't lead to any serious consequence.

Agree.
ProcessCopyOptions has rejected all invalid combinations and assertions are optional.