Hi,
Attached is an updated patch, addressing most of the issues reported so
far. There are various minor tweaks, but the main changes are:
1) regular regression tests, verifying (hopefully) all the various cases
of publication vs. column filters, replica identity check at various
changes and so on
2) pg_dump tests, testing column filters (alone and with row filter)
3) checks of column filter vs. publish_via_partition_root and replica
identity, following the same logic as the row-filter patch (hopefully,
it touches the same places, using the same logic, ...)
That means - with "publish_via_partition_root=false" it's not allowed to
specify column filters on partitioned tables, only for leaf partitions.
And we check column filter vs. replica identity when adding tables to
publications, or whenever we change the replica identity.
The patch is still a bit crude, I'm sure some of the places (especially
the new ones) may need cleanup/recovery. But I think it's much closer to
being committable, I think.
The first two simple patches are adding tests for the row filtering. So
this is not really part of this patch.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company