On 12/17/2017 07:32 PM, Robert Haas wrote:
> Making it use GUC_UNIT_S seems like a good idea to me, but removing
> the mention of seconds from the description doesn't seem like a good
> idea to me.
I took for my model a quick survey of existing GUCs that use
GUC_UNIT_(MS|S|MIN) - most of which do not restate the time unit
in the text description. (It's not a shut-out; some do, but only
a handful.)
I think that makes sense, because once the GUC_UNIT_foo is
specified, you get output like:
select current_setting('worker_spi.naptime');
current_setting
-----------------
10s
and, if you set it for, say, 120000ms or 180min, it will be
displayed as 2min or 3h, etc., making 'seconds' in the text
description a little redundant in the best case—when the
current value is most naturally shown with s—and a little
goofy in the other cases, where the value would be displayed
with min, h, or d, and reading the value combined with the text
description makes the snarky little voice in your head go
"nap for 3 hours seconds??".
-Chap