Re: pgbench - allow to create partitioned tables

Поиск
Список
Период
Сортировка
От Fabien COELHO
Тема Re: pgbench - allow to create partitioned tables
Дата
Msg-id alpine.DEB.2.21.1910010818060.26362@lancre
обсуждение исходный текст
Ответ на Re: pgbench - allow to create partitioned tables  (Amit Kapila <amit.kapila16@gmail.com>)
Ответы Re: pgbench - allow to create partitioned tables
Список pgsql-hackers
Hello Amit,

> 1. ran pgindent
> 2. As per Alvaro's suggestions move few function definitions.
> 3. Changed one or two comments and fixed spelling at one place.

Thanks for the improvements.

Not sure why you put "XXX - " in front of "append_fillfactor" comment, 
though.

> + fprintf(stderr,
> + "no pgbench_accounts table found in search_path\n"
> + "Perhaps you need to do initialization (\"pgbench -i\") in database
> \"%s\"\n", PQdb(con));

> Can anyone else think of a better error message either in wording or
> style for above case?

No better idea from me. The second part is a duplicate from a earlier 
comment, when getting the scale fails.

-- 
Fabien.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andrey Borodin
Дата:
Сообщение: Re: Optimize partial TOAST decompression
Следующее
От: Antonin Houska
Дата:
Сообщение: Re: Attempt to consolidate reading of XLOG page