Re: pgbench's expression parsing & negative numbers
От
Fabien COELHO
Тема
Re: pgbench's expression parsing & negative numbers
Дата
Msg-id
alpine.DEB.2.21.1808101018080.9120@lancre
Ответ на
Re: pgbench's expression parsing & negative numbers (Ibrar Ahmed)
Список
Дерево обсуждения
pgbench's expression parsing & negative numbers Andres Freund <andres@anarazel.de>
Re: pgbench's expression parsing & negative numbers Fabien COELHO <coelho@cri.ensmp.fr>
Re: pgbench's expression parsing & negative numbers Andres Freund <andres@anarazel.de>
Re: pgbench's expression parsing & negative numbers Fabien COELHO <coelho@cri.ensmp.fr>
Re: pgbench's expression parsing & negative numbers Andres Freund <andres@anarazel.de>
Re: pgbench's expression parsing & negative numbers Fabien COELHO <coelho@cri.ensmp.fr>
Re: pgbench's expression parsing & negative numbers Fabien COELHO <coelho@cri.ensmp.fr>
Re: pgbench's expression parsing & negative numbers Fabien COELHO <coelho@cri.ensmp.fr>
Re: pgbench's expression parsing & negative numbers Fabien COELHO <coelho@cri.ensmp.fr>
Re: pgbench's expression parsing & negative numbers Ibrar Ahmed <ibrar.ahmad@gmail.com>
Re: pgbench's expression parsing & negative numbers Fabien COELHO <coelho@cri.ensmp.fr>
Re: pgbench's expression parsing & negative numbers Ibrar Ahmed <ibrar.ahmad@gmail.com>
Re: pgbench's expression parsing & negative numbers Fabien COELHO <coelho@cri.ensmp.fr>
Re: pgbench's expression parsing & negative numbers Andres Freund <andres@anarazel.de>
Re: pgbench's expression parsing & negative numbers Andres Freund <andres@anarazel.de>
Re: pgbench's expression parsing & negative numbers Fabien COELHO <coelho@cri.ensmp.fr>
Re: pgbench's expression parsing & negative numbers Andres Freund <andres@anarazel.de>
Hello, > The following review has been posted through the commitfest application: > make installcheck-world: not tested > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation: not tested > > Patch does not apply cleanly on the master branch, anyways I managed that. Patch work according to specs, and no issue found. > The only minor nit is that you can keep the full comments of function strtoint64 > > /* > * If not errorOK, an error message is printed out. > * If errorOK is true, just return "false" for bad input. > */ Thanks for the review. Attached is a v4, with improved comments on strtoint64 as you requested. I also added 2 "unlikely" compiler directives. -- Fabien.
В списке pgsql-hackers по дате отправления
От: Fabien COELHO
Дата: