Re: [HACKERS] proposal: psql command \graw

Поиск
Список
Период
Сортировка
Искать
От
Fabien COELHO
Тема
Re: [HACKERS] proposal: psql command \graw
Дата
Msg-id
alpine.DEB.2.20.1708240549050.1575@lancre
Ответ на
Список
Дерево обсуждения
[HACKERS] proposal: psql command \graw Pavel Stehule <pavel.stehule@gmail.com>
Re: [HACKERS] proposal: psql command \graw Aleksander Alekseev <a.alekseev@postgrespro.ru>
Re: [HACKERS] proposal: psql command \graw Pavel Stehule <pavel.stehule@gmail.com>
Re: [HACKERS] proposal: psql command \graw Fabien COELHO <coelho@cri.ensmp.fr>
Re: [HACKERS] proposal: psql command \graw Pavel Stehule <pavel.stehule@gmail.com>
Re: [HACKERS] proposal: psql command \graw Pavel Stehule <pavel.stehule@gmail.com>
Re: [HACKERS] proposal: psql command \graw Fabien COELHO <coelho@cri.ensmp.fr>
Re: [HACKERS] proposal: psql command \graw Pavel Stehule <pavel.stehule@gmail.com>
Re: [HACKERS] proposal: psql command \graw Fabien COELHO <coelho@cri.ensmp.fr>
Re: [HACKERS] proposal: psql command \graw Pavel Stehule <pavel.stehule@gmail.com>
Re: [HACKERS] proposal: psql command \graw Fabien COELHO <coelho@cri.ensmp.fr>
Re: [HACKERS] proposal: psql command \graw Pavel Stehule <pavel.stehule@gmail.com>
Re: [HACKERS] proposal: psql command \graw Fabien COELHO <coelho@cri.ensmp.fr>
Re: [HACKERS] proposal: psql command \graw Pavel Stehule <pavel.stehule@gmail.com>
Re: [HACKERS] proposal: psql command \graw Pavel Stehule <pavel.stehule@gmail.com>
Re: [HACKERS] proposal: psql command \graw Pavel Stehule <pavel.stehule@gmail.com>
Re: [HACKERS] proposal: psql command \graw Fabien COELHO <coelho@cri.ensmp.fr>
Re: [HACKERS] proposal: psql command \graw Pavel Stehule <pavel.stehule@gmail.com>
Re: [HACKERS] proposal: psql command \graw Fabien COELHO <coelho@cri.ensmp.fr>
Re: [HACKERS] proposal: psql command \graw Pavel Stehule <pavel.stehule@gmail.com>
Re: [HACKERS] proposal: psql command \graw Fabien COELHO <coelho@cri.ensmp.fr>

Hello Pavel,

I have added the patch to the next commitfest.

Patch applies, compiles, works.

I'm okay with the names graw/graw+, and for having such short-hands.

Missing break in switch, even if last item and useless, because other
items do it... Also should be added at its place in alphabetical order?

"column_header" is somehow redundant with "tuples_only". Use the
existing one instead of adding a new one?

More generally, ISTM that the same effect could be achieved without
adding a new print function, but by setting more options (separator,
...) and calling an existing print function. If so, I think it would
reduce the code size.

Missing help entry.

Missing non regression tests.

Missing documentation.

-- 
Fabien.


В списке pgsql-hackers по дате отправления
От: Bossart, Nathan
Дата:
От: Pavel Stehule
Дата:
FAQ