On Mon, May 13, 2024 at 10:05:03AM -0400, Melanie Plageman wrote:
> Remove the assert and reset the field on which it previously asserted to
> avoid incorrectly emitting NULL-filled tuples from a previous scan on
> rescan.
> - Assert(scan->rs_empty_tuples_pending == 0);
> + scan->rs_empty_tuples_pending = 0;
Perhaps this should document the reason why the reset is done in these
two paths rather than let the reader guess it? And this is about
avoiding emitting some tuples from a previous scan.
> +SET enable_indexonlyscan = off;
> +set enable_indexscan = off;
> +SET enable_seqscan = off;
Nit: adjusting the casing of the second SET here.
--
Michael