Re: Preventing indirection for IndexPageGetOpaque for known-size page special areas

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Preventing indirection for IndexPageGetOpaque for known-size page special areas
Дата
Msg-id YkaP64JvZTMgcHtq@paquier.xyz
обсуждение исходный текст
Ответ на Re: Preventing indirection for IndexPageGetOpaque for known-size page special areas  (Matthias van de Meent <boekewurm+postgres@gmail.com>)
Ответы Re: Preventing indirection for IndexPageGetOpaque for known-size page special areas
Список pgsql-hackers
On Thu, Mar 31, 2022 at 12:09:35PM +0200, Matthias van de Meent wrote:
> PageInit MAXALIGNs the size of the special area that it receives as an
> argument; so any changes to the page header that would misalign the
> value would be AM-specific; in which case it is quite unlikely that
> this is the right accessor for your page's special area.

Right.  I'd still be tempted to keep that per-AM rather than making
the checks deeper with one extra macro layer in the page header or
with a different macro that would depend on the opaque type, though.
Like in the attached, for example.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Fabien COELHO
Дата:
Сообщение: Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: logical decoding and replication of sequences